-
-
Notifications
You must be signed in to change notification settings - Fork 376
pgtap function to check returns geom #2818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pgtap function to check returns geom #2818
Conversation
WalkthroughThis pull request modifies several SQL test scripts by reducing the number of planned tests and removing specific return type validation (using Changes
Sequence Diagram(s)sequenceDiagram
participant Tester as Test Suite
participant FRG as function_returns_geom
participant PG as pg_proc
Tester->>+FRG: Call function_returns_geom('function_name')
FRG->>+PG: Query pg_proc for return type of 'function_name'
PG-->>-FRG: Return function return type
FRG-->>-Tester: Evaluate and return geometry verification result
Assessment against linked issues
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (12)
⏰ Context from checks skipped due to timeout of 90000ms (16)
🔇 Additional comments (13)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Fixes #2809 .
Changes proposed in this pull request:
@pgRouting/admins
Summary by CodeRabbit
These improvements enhance the consistency and efficiency of core functionality verifications, contributing to a more robust and reliable system.