Skip to content

Port changes contraction hierarchies and using const char #2872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Apr 25, 2025
Merged

Port changes contraction hierarchies and using const char #2872

merged 14 commits into from
Apr 25, 2025

Conversation

cvvergara
Copy link
Member

AuBousquet and others added 12 commits April 24, 2025 20:06
@AuBousquet @cvvergara
pgr_contractionHierarchies - C / C++ src files
7033e78 
(cherry picked from commit 9c8bc8b)
@AuBousquet @cvvergara
pgr_contractionHierarchies - C / C++ include files
a1fe24a 
(cherry picked from commit 646be85)
@AuBousquet @cvvergara
pgr_contractionHierarchies - SQL files
c8dd88f 
(cherry picked from commit d2b0c41)
@AuBousquet @cvvergara
pgr_contractionHierarchies - PgTap SQL tests
cb827a9 
(cherry picked from commit 6271ee4)
@AuBousquet @cvvergara
pgr_contractionHierarchies - Test data
c2ea2b2 
(cherry picked from commit 64e0011)
@AuBousquet @cvvergara
pgr_contractionHierarchies - Doc queries files
56f3089 
(cherry picked from commit f580643)
@AuBousquet @cvvergara
pgr_contractionHierarchies - Documentation .rst files
410691e 
(cherry picked from commit 27b978f)
@cvvergara
pgr_contractionHierarchies fixes
9d89b0c 
sql:

- Order of optional parameters: "directed" is first
- forbidden_vertices -> forbidden

General fixes:

- Fixing licenses
- Removed trailing spaces on files
- Adjust to parameters names and order

pgtap:

- The function is new on 3.8.0
- Adjusting plans and skip message

build:

- Adding pgr_contractionHierarchies signatures in 3.8

doc queries:

- Capitalizing postgreSQL key words

Doc:

- Added Experimental keyword

Fixing C/C++ warnings:

- template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
- no member named remove_edge in namespace boost [clang-diagnostic-error]
- no member named make_iterator_range in namespace boost [clang-diagnostic-error]

(cherry picked from commit 64b6dc5)
@cvvergara
Adding contributor's name to documetation.
6514388 
(cherry picked from commit cc71f5c)
@cvvergara
Following some rabbit suggestions
b64043c 
(cherry picked from commit 3c45df0)
@cvvergara
(docqueries) Updating a result file
cc9aa3a 
(cherry picked from commit 6095575)
@cvvergara
Using const char on drivers
b5007ad
@cvvergara cvvergara added this to the Release 4.0.0 milestone Apr 25, 2025
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Apr 25, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@cvvergara cvvergara merged commit 1f4587d into pgRouting:develop Apr 25, 2025
25 of 26 checks passed
@cvvergara cvvergara deleted the port-changes-contraction-hierarchies-and-using-const-char branch April 25, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Administrative Port commits
Projects
None yet
Milestone
Release 4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@cvvergara @AuBousquet