Skip to content

T16741 router uri with numbers colons #16745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

niden
Copy link
Member

@niden niden commented Apr 5, 2025

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Small description of change:

Added Phalcon\Mvc\Router::setUriSource() to allow URI processing from $_GET['url'] or $_SERVER['REQUEST_URI'] as it was in v3
Fixed Phalcon\Mvc\Router to correctly handle numeric URI parts as it was in v3

Thanks

@niden niden added bug A bug report status: medium Medium 5.0 The issues we want to solve in the 5.0 release labels Apr 5, 2025
@niden niden requested a review from Jeckerson April 5, 2025 15:49
@niden niden self-assigned this Apr 5, 2025
@niden niden changed the base branch from master to 5.0.x April 5, 2025 15:51
@niden niden merged commit 0209830 into phalcon:5.0.x Apr 5, 2025
42 checks passed
@niden niden deleted the T16741-router-uri-with-numbers-colons branch April 5, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Router fails to match routes starting with "/number:number/" due to internal parse_url() behavior
1 participant