Skip to content

tweak(ui): sanitize secret when export yaml #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 10, 2024
Merged

tweak(ui): sanitize secret when export yaml #74

merged 3 commits into from
Apr 10, 2024

Conversation

shhdgit
Copy link
Member

@shhdgit shhdgit commented Apr 8, 2024

Why are these changes needed?

Remove the secret when exporting to avoid leaking the secret key.

Related issue number

Checks

  • I've included any doc changes needed for https://github.com/pingcap/LinguFlow/.
  • I've added tests (if relevant) corresponding to the changes introduced in this PR.
  • I've made sure all auto checks have passed.

@shhdgit
Copy link
Member Author

shhdgit commented Apr 9, 2024

@freedeaths done~

freedeaths
freedeaths approved these changes Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@freedeaths freedeaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shhdgit shhdgit merged commit decb188 into main Apr 10, 2024
1 check passed
@shhdgit shhdgit deleted the tweak-sanitize-secret branch April 10, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freedeaths freedeaths freedeaths approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shhdgit @freedeaths