br: Log backup sync state with kernel br periodically #6147
+345
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6147 +/- ##
==========================================
+ Coverage 57.19% 60.04% +2.84%
==========================================
Files 259 263 +4
Lines 33233 46257 +13024
==========================================
+ Hits 19008 27775 +8767
- Misses 12291 16358 +4067
- Partials 1934 2124 +190
🚀 New features to boost your workflow:
|
RidRisR
changed the title
|
/run-pull-e2e-kind-br |
WangLe1321
reviewed
Apr 23, 2025
| @@ -838,7 +844,7 @@ func (bm *backupManager) makeBRBackupJob(backup *v1alpha1.Backup) (*batchv1.Job, | |||
| Name: label.BackupJobLabelVal, | |||
| Image: bm.deps.CLIConfig.TiDBBackupManagerImage, | |||
| Args: args, | |||
| ImagePullPolicy: corev1.PullIfNotPresent, | |||
| ImagePullPolicy: corev1.PullAlways, | |||
There was a problem hiding this comment.
Why change the ImagePullPolicy?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
What is changed and how does it work?
Code changes
Tests
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.