fix: correct instance label handling for DM Discovery component #6150
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
The topologySpreadConstraints for the dm-discovery pod were not applied correctly because the instance label used in the constraints did not include the -dm suffix.
This caused a mismatch between the constraint's label selector and the actual pod labels, potentially leading to unintended pod scheduling behavior.
Close #6149
What is changed and how does it work?
The logic that sets the app.kubernetes.io/instance label in topologySpreadConstraints has been updated.
For the dm-discovery component, the instance label now appends a -dm suffix to match the actual label used on the pod.
This ensures that the topology spread constraints work correctly by aligning with the pod's label.
Code changes
Tests
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.