Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br/lightning: Apply pd_enable_follower_handle_region to Lightning/BR #59783

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

okJiang
Copy link
Member

@okJiang okJiang commented Feb 26, 2025

What problem does this PR solve?

Issue Number: close #58651

Problem Summary:

What changed and how does it work?

  • Get pd_enable_follower_handle_region from TiDB and set it to pd client.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 26, 2025
Signed-off-by: okJiang <[email protected]>
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 10.41667% with 43 lines in your changes missing coverage. Please review.

Project coverage is 73.6073%. Comparing base (db15d43) to head (f60913e).
Report is 10 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #59783        +/-   ##
================================================
+ Coverage   72.9550%   73.6073%   +0.6523%     
================================================
  Files          1699       1729        +30     
  Lines        469293     479528     +10235     
================================================
+ Hits         342373     352968     +10595     
+ Misses       105847     104609      -1238     
- Partials      21073      21951       +878     
Flag Coverage Δ
integration 45.6060% <11.3636%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 45.0088% <0.0000%> (-0.0447%) ⬇️

Signed-off-by: okJiang <[email protected]>
Signed-off-by: okJiang <[email protected]>
@okJiang
Copy link
Member Author

okJiang commented Feb 27, 2025

/test pull-br-integration-test

Copy link

tiprow bot commented Feb 27, 2025

@okJiang: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test pull-br-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 27, 2025
Signed-off-by: okJiang <[email protected]>
Signed-off-by: okJiang <[email protected]>
Signed-off-by: okJiang <[email protected]>
@okJiang
Copy link
Member Author

okJiang commented Feb 27, 2025

/retest

Copy link

ti-chi-bot bot commented Feb 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 27, 2025
Copy link

ti-chi-bot bot commented Feb 27, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-27 07:33:53.915676015 +0000 UTC m=+513981.868834282: ☑️ agreed by YuJuncen.
  • 2025-02-27 10:37:13.338091789 +0000 UTC m=+524981.291250055: ☑️ agreed by lance6716.

Signed-off-by: okJiang <[email protected]>
Signed-off-by: okJiang <[email protected]>
Signed-off-by: okJiang <[email protected]>
@okJiang
Copy link
Member Author

okJiang commented Feb 28, 2025

/retest

Signed-off-by: okJiang <[email protected]>
Copy link

tiprow bot commented Feb 28, 2025

@okJiang: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
fast_test_tiprow f60913e link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

ti-chi-bot bot commented Feb 28, 2025

@okJiang: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/build f60913e link true /test build
idc-jenkins-ci-tidb/unit-test f60913e link true /test unit-test
idc-jenkins-ci-tidb/check_dev_2 f60913e link true /test check-dev2
pull-br-integration-test f60913e link true /test pull-br-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply pd_enable_follower_handle_region to Lightning/BR
3 participants