-
Notifications
You must be signed in to change notification settings - Fork 412
Support (left outer) (anti) semi join in hash join v2 #10133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: gengliqi <[email protected]>
Signed-off-by: gengliqi <[email protected]>
Signed-off-by: gengliqi <[email protected]>
Signed-off-by: gengliqi <[email protected]>
Signed-off-by: gengliqi <[email protected]>
Signed-off-by: gengliqi <[email protected]>
Signed-off-by: gengliqi <[email protected]>
Signed-off-by: gengliqi <[email protected]>
Signed-off-by: gengliqi <[email protected]>
Signed-off-by: gengliqi <[email protected]>
Signed-off-by: gengliqi <[email protected]>
Signed-off-by: gengliqi <[email protected]>
Signed-off-by: gengliqi <[email protected]>
Signed-off-by: gengliqi <[email protected]>
Signed-off-by: gengliqi <[email protected]>
Signed-off-by: gengliqi <[email protected]>
Signed-off-by: gengliqi <[email protected]>
Signed-off-by: gengliqi <[email protected]>
Signed-off-by: gengliqi <[email protected]>
Signed-off-by: gengliqi <[email protected]>
Signed-off-by: gengliqi <[email protected]>
Signed-off-by: gengliqi <[email protected]>
Signed-off-by: gengliqi <[email protected]>
Signed-off-by: gengliqi <[email protected]>
Signed-off-by: gengliqi <[email protected]>
Signed-off-by: gengliqi <[email protected]>
Signed-off-by: gengliqi <[email protected]>
Signed-off-by: gengliqi <[email protected]>
Signed-off-by: gengliqi <[email protected]>
Signed-off-by: gengliqi <[email protected]>
Signed-off-by: gengliqi <[email protected]>
Signed-off-by: gengliqi <[email protected]>
Signed-off-by: gengliqi <[email protected]>
Signed-off-by: gengliqi <[email protected]>
…to join-v2-semi-join
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: gengliqi <[email protected]>
Signed-off-by: gengliqi <[email protected]>
Signed-off-by: gengliqi <[email protected]>
1809fae
to
4ba216d
Compare
Signed-off-by: gengliqi <[email protected]>
Signed-off-by: gengliqi <[email protected]>
Signed-off-by: gengliqi <[email protected]>
Signed-off-by: gengliqi <[email protected]>
Signed-off-by: gengliqi <[email protected]>
Signed-off-by: gengliqi <[email protected]>
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates various components to support hash join v2 and (anti) semi join operations by introducing new serialization facilities and failpoint flags. It also adds tests for the new serializeByteSize methods across multiple column types.
- Updated Block::swap to handle new members (start_offset, segment_row_id_col).
- Added new failpoint flags for join v2 probe enable/disable.
- Introduced serializeByteSize implementations and corresponding tests in several Column classes.
Reviewed Changes
Copilot reviewed 45 out of 46 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
dbms/src/Core/Block.cpp | Swapped new members to ensure Block swap consistency. |
dbms/src/Common/FailPoint.cpp | Added new failpoints for join v2 probe enable and disable. |
dbms/src/Common/ColumnNTAlignBuffer.h | Updated comment wording for clarity. |
dbms/src/Columns/tests/gtest_column_misc.cpp | Added tests covering new serializeByteSize API for various column types. |
dbms/src/Columns/filterColumn.cpp | Added explicit instantiation for filterImpl with char pointer types. |
Other Column files | Provided serializeByteSize implementations (or exceptions) consistent with design. |
Files not reviewed (1)
- dbms/CMakeLists.txt: Language not supported
@@ -326,6 +326,12 @@ INSTANTIATE(Decimal32, DecimalPaddedPODArray<Decimal32>) | |||
INSTANTIATE(Decimal64, DecimalPaddedPODArray<Decimal64>) | |||
INSTANTIATE(Decimal128, DecimalPaddedPODArray<Decimal128>) | |||
INSTANTIATE(Decimal256, DecimalPaddedPODArray<Decimal256>) | |||
// Cannot use INSTANTIATE micro because `const T * data_pos` + `T: char *` will be intepreted as `const char **` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment contains a spelling error: 'intepreted' should be corrected to 'interpreted'.
// Cannot use INSTANTIATE micro because `const T * data_pos` + `T: char *` will be intepreted as `const char **` | |
// Cannot use INSTANTIATE micro because `const T * data_pos` + `T: char *` will be interpreted as `const char **` |
Copilot uses AI. Check for mistakes.
What problem does this PR solve?
Issue Number: ref #9060
Problem Summary:
What is changed and how it works?
Should merge after #9956.
Check List
Tests
Side effects
Documentation
Release note