Skip to content

Enhancement CBO (#2563) #2566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #2563

What problem does this PR solve?

After this PR, TiSpark will choose the store according to the min cost between tikv table scan, tikv index scan and tifalsh scan.

Before this pr, TiSpark only compare tikv table scan and tiflash scan, and usually choose tiflash once the table has tiflash replica.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 14, 2022
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Oct 14, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Daemonxiao
  • shiyuhang0

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@shiyuhang0
Copy link
Member

/run-all-tests

@shiyuhang0
Copy link
Member

/run-all-tests

@shiyuhang0
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member Author

@shiyuhang0: /merge in this pull request requires 2 approval(s).

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@shiyuhang0
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 77d9068

@ti-chi-bot ti-chi-bot merged commit e6fd049 into pingcap:release-2.5 Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants