-
Notifications
You must be signed in to change notification settings - Fork 170
[Stage Plugins] Add PipedService API to handle commands of SkipStage and ApproveStage #5521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: t-kikuc <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5521 +/- ##
==========================================
- Coverage 26.43% 26.43% -0.01%
==========================================
Files 464 465 +1
Lines 49786 49858 +72
==========================================
+ Hits 13163 13182 +19
- Misses 35569 35621 +52
- Partials 1054 1055 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: t-kikuc <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I updated to remove That will be executed in Piped in order to simplify handling commands in plugin-side. |
What this PR does:
Added two rpcs of plugin->piped:
ListStageCommands()
ReportCommandHandled()
Why we need it:
cf. See here for the overview of handling SkipStage and ApproveStage:
#5367 (comment)
Which issue(s) this PR fixes:
Part of #5367
Does this PR introduce a user-facing change?: