Skip to content

Implement SDK BuildPipelineSyncStages methods #5584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 19, 2025

Conversation

Warashi
Copy link
Contributor

@Warashi Warashi commented Feb 19, 2025

What this PR does:

as title

Why we need it:

to implement SDK

Which issue(s) this PR fixes:

Part of #5529

Does this PR introduce a user-facing change?: No

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

@Warashi Warashi force-pushed the plugin-sdk-pipeline-sync-plugins branch from 1c2db99 to decddaa Compare February 19, 2025 04:28
@Warashi Warashi marked this pull request as ready for review February 19, 2025 04:31
khanhtc1202
khanhtc1202 previously approved these changes Feb 19, 2025
t-kikuc
t-kikuc previously approved these changes Feb 19, 2025
@Warashi Warashi enabled auto-merge (squash) February 19, 2025 04:31
Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
@Warashi Warashi dismissed stale reviews from t-kikuc and khanhtc1202 via c6654be February 19, 2025 04:33
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 0% with 66 lines in your changes missing coverage. Please review.

Project coverage is 26.24%. Comparing base (b099bc0) to head (c6654be).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/plugin/sdk/deployment.go 0.00% 64 Missing ⚠️
pkg/app/pipedv1/plugin/example/plugin.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5584      +/-   ##
==========================================
- Coverage   26.26%   26.24%   -0.02%     
==========================================
  Files         471      471              
  Lines       50359    50421      +62     
==========================================
+ Hits        13225    13235      +10     
- Misses      36072    36125      +53     
+ Partials     1062     1061       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Warashi Warashi merged commit c527965 into master Feb 19, 2025
16 of 18 checks passed
@Warashi Warashi deleted the plugin-sdk-pipeline-sync-plugins branch February 19, 2025 04:41
@github-actions github-actions bot mentioned this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants