Skip to content

Fix cancel handling in pipedv1 scheduler #5597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 4, 2025

Update comments on cancelled case

4d96f03
Select commit
Loading
Failed to load commit list.
Merged

Fix cancel handling in pipedv1 scheduler #5597

Update comments on cancelled case
4d96f03
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Feb 25, 2025 in 1s

26.24% (-0.04%) compared to acde5ae

View this Pull Request on Codecov

26.24% (-0.04%) compared to acde5ae

Details

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 26.24%. Comparing base (acde5ae) to head (4d96f03).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
pkg/app/pipedv1/controller/scheduler.go 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5597      +/-   ##
==========================================
- Coverage   26.28%   26.24%   -0.04%     
==========================================
  Files         470      473       +3     
  Lines       50353    50450      +97     
==========================================
+ Hits        13234    13242       +8     
- Misses      36059    36146      +87     
- Partials     1060     1062       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.