[WaitApproval] Notify events of Approved/WaitApproval in Piped side #5632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Signed-off-by: t-kikuc <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5632 +/- ##
==========================================
+ Coverage 26.58% 26.62% +0.04%
==========================================
Files 477 478 +1
Lines 50657 50818 +161
==========================================
+ Hits 13465 13531 +66
- Misses 36134 36221 +87
- Partials 1058 1066 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
t-kikuc
commented
Mar 6, 2025
| if err != nil { | ||
| s.logger.Error("failed to get the list of users", zap.Error(err)) | ||
| } | ||
| approver, _ := s.metadataStore.StageGet(stage.Id, "pipecd.dev.Approver") // TODO: Make the key to be a const. |
There was a problem hiding this comment.
[help wanted]
How about not notifying if 'approver' is empty?
For the situation like the stage ended due to reasons other than approvals.
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
|
This PR was closed because it has been stalled for 7 days with no activity. Feel free to reopen if still applicable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Instead of triggering the events exactly at start/end of the approval, trigger them at start/end of the stage.
WaitApprovalEvent: Trigger at the same timing asStageStartedApprovedEvent: Trigger at the same timing asStageSucceededapproverfield will be passed from a plugin indirectly via metadataStoreWhy we need it:
Instead of #5613, this PR does not add RPCs for simplicity of the interface.
Which issue(s) this PR fixes:
Part of #5367
Does this PR introduce a user-facing change?: