Skip to content

Implemented ListStageCommands() on piped side #5685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 28, 2025
Merged

Conversation

t-kikuc
Copy link
Member

@t-kikuc t-kikuc commented Mar 19, 2025

What this PR does:

as title

Note: Later I'll implement reporting the commands.

Why we need it:

To list stage commands from a plugin.

Which issue(s) this PR fixes:

Follows #5639
Fixes #5367

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Copy link

codecov bot commented Mar 19, 2025

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 25.76%. Comparing base (5079ca7) to head (5e8bdec).
Report is 19 commits behind head on master.

Files with missing lines Patch % Lines
pkg/app/pipedv1/apistore/commandstore/store.go 0.00% 13 Missing ⚠️
pkg/app/pipedv1/cmd/piped/grpcapi/plugin_api.go 0.00% 5 Missing ⚠️
pkg/app/pipedv1/cmd/piped/piped.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5685      +/-   ##
==========================================
- Coverage   25.76%   25.76%   -0.01%     
==========================================
  Files         476      476              
  Lines       50976    50981       +5     
==========================================
  Hits        13135    13135              
- Misses      36843    36848       +5     
  Partials      998      998              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t-kikuc t-kikuc merged commit 7634dac into master Mar 28, 2025
16 of 18 checks passed
@t-kikuc t-kikuc deleted the plugin/commands-piped branch March 28, 2025 05:42
@github-actions github-actions bot mentioned this pull request Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[epic][plugin] Implement Stage Plugins
3 participants