Skip to content

Use new plugin SDK interface to build kubernetes_multicluster plugin #5702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2025

Conversation

Warashi
Copy link
Contributor

@Warashi Warashi commented Mar 26, 2025

What this PR does:

as title

Why we need it:

Because we introduced a new plugin SDK interface in #5698, I want to migrate the k8s multicluster plugin.
After migrating all plugins, I'll remove and refactor old SDK interfaces.

Which issue(s) this PR fixes:

Follows #5698
Part of #5530

Does this PR introduce a user-facing change?: No

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Copy link

codecov bot commented Mar 26, 2025

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 25.65%. Comparing base (d84746b) to head (009b4b2).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...app/pipedv1/plugin/kubernetes_multicluster/main.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5702   +/-   ##
=======================================
  Coverage   25.64%   25.65%           
=======================================
  Files         481      481           
  Lines       51254    51259    +5     
=======================================
+ Hits        13145    13151    +6     
+ Misses      37111    37110    -1     
  Partials      998      998           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Warashi Warashi marked this pull request as ready for review March 26, 2025 05:26
Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Warashi Warashi enabled auto-merge (squash) March 26, 2025 05:28
@Warashi Warashi merged commit 1ebe879 into master Mar 26, 2025
17 of 18 checks passed
@Warashi Warashi deleted the k8s-multicluster-plugin-new-plugin-sdk-interface branch March 26, 2025 07:43
@github-actions github-actions bot mentioned this pull request Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants