Skip to content

Remove Name and Version methods from plugins #5704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 26, 2025

Conversation

Warashi
Copy link
Contributor

@Warashi Warashi commented Mar 26, 2025

What this PR does:

as title

Why we need it:

These are requirements of the old SDK interfaces so that we can delete them.

Which issue(s) this PR fixes:

Follows #5703

Does this PR introduce a user-facing change?: No

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

@Warashi Warashi marked this pull request as ready for review March 26, 2025 08:36
Copy link

codecov bot commented Mar 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.73%. Comparing base (c65a5f4) to head (405e13e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5704      +/-   ##
==========================================
+ Coverage   25.72%   25.73%   +0.01%     
==========================================
  Files         480      480              
  Lines       51115    51095      -20     
==========================================
  Hits        13147    13147              
+ Misses      36970    36950      -20     
  Partials      998      998              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Warashi Warashi merged commit 72a3cfd into master Mar 26, 2025
18 checks passed
@Warashi Warashi deleted the remove-name-and-version-methods-from-plugins branch March 26, 2025 08:47
@github-actions github-actions bot mentioned this pull request Apr 3, 2025
@github-actions github-actions bot mentioned this pull request May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants