Skip to content

Fix error on values pass to action-event-register #5708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025
Merged

Conversation

khanhtc1202
Copy link
Member

@khanhtc1202 khanhtc1202 commented Mar 27, 2025

What this PR does:

Why we need it:

Values passed to event-register-actions contains some linebreak, which led to execution errors. Let's disable these values this time
ref: https://github.com/pipe-cd/pipecd/actions/runs/14100088870/job/39494761791#step:4:102

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

@khanhtc1202 khanhtc1202 enabled auto-merge (squash) March 27, 2025 06:59
Copy link

codecov bot commented Mar 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.73%. Comparing base (3290f76) to head (44bafca).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5708      +/-   ##
==========================================
+ Coverage   25.71%   25.73%   +0.01%     
==========================================
  Files         480      480              
  Lines       51095    51095              
==========================================
+ Hits        13141    13147       +6     
+ Misses      36956    36950       -6     
  Partials      998      998              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@khanhtc1202 khanhtc1202 merged commit 0363ce6 into master Mar 27, 2025
18 checks passed
@khanhtc1202 khanhtc1202 deleted the fix-workflow branch March 27, 2025 07:11
@github-actions github-actions bot mentioned this pull request Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants