Normalize resource key before grouping manifests to convert default namespace to empty #5774
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
as title
Why we need it:
When no namespace is set for resources in the
app.pipecd.yaml
or actual resource manifests, there is the diffs like below.When loading manifests from git, set an empty string as the namespace if no namespace is set.
But when loading manifests from actual clusters, the value
default
is set as the namespace.So we need to normalize the namespace before comparing the manifests from git and the ones from the actual cluster.
Especially set empty value considering the case when no namespace is set in the manifests from git repo.
Which issue(s) this PR fixes:
Part of #5006 #5764
Does this PR introduce a user-facing change?: