Fixed to add annotations after calling loader.LoadManifests #5777
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Move the logic to add the annotation logic into the plugin side.
Why we need it:
When creating the commit, the fixes are not related to the target app, there is a diff for
pipecd.dev/commit-hash
.The current logic detects diffs that are defined in the git repo but do not exist in the actual resource.
So, IMO, we shouldn't include them when loading manifests from the git repo because these annotations are set automatically before applying resources on the piped side.
Which issue(s) this PR fixes:
Part of #5006 #5764
Does this PR introduce a user-facing change?: