Skip to content

Cleanup Codes related to FileDB #5786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Okabe-Junya
Copy link
Contributor

@Okabe-Junya Okabe-Junya commented Apr 28, 2025

What this PR does:

Remove all FileDB-related code from the codebase

Why we need it:

See #5652

Which issue(s) this PR fixes:

Ref. #5652
(Not close, since I haven't cleanup-ed docs yet / I haven't decided how to migrate yet)

Note:

Per PipeCD’s maintenance and release policy, you’re welcome to target this PR at a different branch or leave it unmerged for a while.
I respect the maintenance team’s policy :)

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change: Users will no longer be able to configure FileDB as PipeCD datastore.
  • How to migrate (if breaking change):

Signed-off-by: Junya Okabe <[email protected]>
Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khanhtc1202
Copy link
Member

Hi @Okabe-Junya Thanks for the commit 👍
This feature deprecation issue could be a bit more complicated than the removed code in this PR, so we added hold label for now. If you feel interest on this issue, please join the public dev mtg or CNCF #pipecd channel for further discussion.
We really appreciate your interest, thank you 😁

@Okabe-Junya
Copy link
Contributor Author

Thank you - I understand how complex this issue can become, and I will fully respect the team’s opinions.

Thanks also for sharing the Slack channel and meeting details; I’ll check them out :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants