Skip to content

[k8s Plugin] Implement primary rollout stage #5791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025

Conversation

Warashi
Copy link
Contributor

@Warashi Warashi commented May 1, 2025

What this PR does:

as title

Why we need it:

We want to support the current k8s platform feature with the plugin-arch piped.

Which issue(s) this PR fixes:

Part of #5764

Does this PR introduce a user-facing change?: No

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Shinnosuke Sawada-Dazai <[email protected]>
Copy link

codecov bot commented May 1, 2025

Codecov Report

Attention: Patch coverage is 0% with 145 lines in your changes missing coverage. Please review.

Project coverage is 27.12%. Comparing base (e92520b) to head (9db9eed).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...pp/pipedv1/plugin/kubernetes/deployment/primary.go 0.00% 142 Missing ⚠️
...g/app/pipedv1/plugin/kubernetes/deployment/misc.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5791      +/-   ##
==========================================
- Coverage   27.19%   27.12%   -0.08%     
==========================================
  Files         507      507              
  Lines       53533    53675     +142     
==========================================
  Hits        14557    14557              
- Misses      37863    38005     +142     
  Partials     1113     1113              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Warashi
Copy link
Contributor Author

Warashi commented May 1, 2025

I want to add tests after merging #5790 because it changes the config structure.

@Warashi Warashi marked this pull request as ready for review May 1, 2025 00:55
@Warashi Warashi mentioned this pull request May 1, 2025
32 tasks
@t-kikuc t-kikuc merged commit b5d9fc9 into master May 1, 2025
19 of 22 checks passed
@t-kikuc t-kikuc deleted the k8s-plugin-primary-rollout branch May 1, 2025 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants