Added rpm build using cargo generate-rpm #403
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobgkau
previously approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Tested on Fedora 40.
Before this worked, I did need to run cargo install cargo-generate-rpm in order for the cargo generate-rpm command to be available.
After that, running make rpm produced an RPM file that I was able to install. After installation, I needed to manually start com.system76.PowerDaemon.service before subcommands such as system76-power graphics would work (before that, I got org.freedesktop.DBus.Error.ServiceUnknown: The name is not activatable).
If either of those sound like something additional needs to be added to the code/config to reduce the amount of manual steps, then further changes can be made. Otherwise, this seems to work as expected. @pop-os/engineering can decide whether this is something we want to include upstream.
|
I created, this, and am glad to see its getting traction! That said, I do have a couple issues running it on fedora I haven't really spent any time debugging.
com.system76.PowerDaemon.service logsActually, now that I take the time to look at it, it looks like something's happening with the System logsNot at all related to packaging this as an RPM, though 😉 |
Added metadata needed to Cargo.toml, and an `rpm` target to the Makefile
|
@jacobgkau Actually, thanks for spurring me to investigate this! 😀 It looks like system76-power conflicts with the built-in power-profile-daemon: pop-os/pop#3234 From my logs, it looks like power-profile-daemon switching modes is what causes system76-power to stop. I added a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added metadata needed to Cargo.toml, and an
rpmtarget to the Makefile.Caveat: I know very little about building RPMs, so I don't know if any of this is right or best-practices. However, it works on my machine™.