Add support for Pushover custom sounds #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om dropdown select to typeahead list, default empty string; (2) fallback to "pushover" sound only if submitting an empty string
svobs
force-pushed
the
pushover-custom-sounds
branch
from
090fea3 to
8a7c5ef
Compare
|
@potrudeau Can you please merge this? |
|
Nice work! |
@elvirusDE Sorry I didn't get to this sooner. I created a fork from this PR and published it. Search for the plugin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements issue #25: Simple change which allows custom sounds to be specified for Pushover messages.
This patch:
Soundelement in the UI from a dropdown to a "typeahead" text field which suggests values for the default sounds as the user types.Nothing fancy. It won't provide a list of the user's custom sounds, but it shouldn't be too hard for a user to test out the switch to guard against typos.