-
-
Notifications
You must be signed in to change notification settings - Fork 624
Properly filter .NET build events for configuration #2215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly filter .NET build events for configuration #2215
Conversation
It looks like the CI workflow failed due to a network issue. Is there a way to re-run it? https://github.com/premake/premake-core/actions/runs/9273887065/job/25514966115?pr=2215 |
To keep parity in support between C# and C++ projects, would you mind adding support there and adding the corresponding unit tests? |
Hi @nickclark2016! I guess I was under the assumption this only affected C# project file generation. What did you have in mind for the C++ side? |
I'm not 100% sure that C++ has the problem, but I'd expect the same behavior (allowing per config steps). |
It looks like C++ does not have this problem. The post build events are properly filtered. Minimal example is below using the same version of premake:
Thanks! |
Just checking back in to see if there is anything remaining to be actioned on this |
Bump |
closes #2214
What does this PR do?
This change properly generates per-configuration conditions for build events with .NET projects rather than pulling build events from the project's "first" configuration
How does this PR change Premake's behavior?
Allows configuration filters to work as expected with .NET project generation