-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Add QueryType to QueryContext in event listener API #25005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know you have another PR to add the query type to the session. I actually am not sure if it really belongs in the session. If it does end up in the session, we should add it to the SessionRepresentation object here instead
@@ -335,7 +335,7 @@ private static QueryContext createDummyQueryContext() | |||
Optional<String> catalog = Optional.of("dummyCatalog"); | |||
Optional<String> schema = Optional.of("dummySchema"); | |||
Optional<ResourceGroupId> resourceGroupId = Optional.of(new ResourceGroupId("dummyGroupId")); | |||
|
|||
Optional<QueryType> queryType = Optional.of(QueryType.CONTROL); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional<QueryType> queryType = Optional.of(QueryType.CONTROL); | |
Optional<QueryType> queryType = Optional.of(CONTROL); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Description
Enhance event listener API by adding QueryType to QueryContext
Motivation and Context
Resolvers #25004
Impact
Adds QueryType to QueryContext
Test Plan
UTs
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.