Enable access control row filters and masks for views #25052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry-pick of trinodb/trino@84429d8 This implements getRowFilters and getColumnMasks in ViewAccessControl. Another commit will enalbe filters and masks to be applied on views during analysis. Co-authored-by: Martin Traverso <[email protected]>
prestodb-ci
requested review from
a team,
jp-sivaprasad and
auden-woolfson
and removed request for
a team
The planner for Table node was bailing out early if the table reference corresponded to a view or named query without attaching any masks or filters that may have been resolved. Cherry-pick of trinodb/trino@6721cfa Add filters and masks to processView in StatementAnalyzer, and move duplicate code to analyze filters and masks into common analyzeFiltersAndMasks method. Co-authored-by: Martin Traverso <[email protected]>
BryanCutler
force-pushed
the
qaag-filter-mask-views-25025
branch
from
7db6c6d to
c5337b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This enables adding row filters and column masks from an access control implementation to view.
Closes #25025
Motivation and Context
The recent addition of access control row filters and column masks from #24278 worked for tables, but not for views. It is import for security that views and materialized views apply row filters and column masks from access control.
Impact
No change in SPI.
Test Plan
Unit tests added to verify filters and masks are correctly applied to views.
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.