Revert "Change array_top_n to return null on bad n" #25101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 91c2c54.
prestodb-ci
requested review from
a team,
nmahadevuni and
pratyakshsharma
and removed request for
a team
ZacBlanco
approved these changes
May 13, 2025
hantangwangd
approved these changes
May 13, 2025
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #24729
array_top_n is a SQL function in Presto, vs Velox has a native implementation. Both implementations throw Exception for n < 0, which is consistent. https://github.com/facebookincubator/velox/blob/main/velox/functions/prestosql/ArrayFunctions.h#L755
The issue is mostly because Presto Java doesn't process "try" correctly on SQL functions in general. We should investigate at that broad level. The current fix is incorrect imo.