Improve GraphQL union types formatting #15870
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fisker
changed the title
fisker
reviewed
Jan 3, 2024
|
@fisker added changes. Thank you for your feedback |
fisker
reviewed
Jan 4, 2024
fisker
reviewed
Jan 4, 2024
fisker
approved these changes
Jan 4, 2024
|
Thank you @fisker for reviewing and approving. is this PR good to merge ? |
|
Let's wait for other maintainers to review, please be patient. |
|
Code changes looks good to me, but I concern for #14234 (comment). We should treat this as a breaking change. |
|
It has been supported for 6 years, I think we can merge this. |
sosukesuzuki
approved these changes
Jan 7, 2024
|
Thank you @fisker & @sosukesuzuki for reviewing this PR. This was my first contribution to Prettier, please feel free to tag me or assign me any other |
medikoo
pushed a commit
to medikoo/prettier-elastic
that referenced
this pull request
Feb 17, 2024
* Fix:14234 added fix for formating graphql union type * Fix:14234 clean up code and push the fix * Fix:14234 added test cases * Fix:14234 added changelog entry * Fix:14234 cleanup changelog entry * Fix:14234 cleanup changelog * Update changelog_unreleased/graphql/15870.md * Update changelog_unreleased/graphql/15870.md --------- Co-authored-by: fisker Cheung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue: 14234 - Improve GraphQL union types formatting
Fixes #14234
Checklist
docs/directory).changelog_unreleased/*/XXXX.mdfile followingchangelog_unreleased/TEMPLATE.md.✨Try the playground for this PR✨