Skip to content

drop !important from details styling #2611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2024

Conversation

keithamus
Copy link
Contributor

What are you trying to accomplish?

Fixes #2592

What approach did you choose and why?

Removed !important

What should reviewers focus on?

Can these changes ship as is?

  • Yes, this PR does not depend on additional changes. 🚢

@keithamus keithamus requested a review from a team as a code owner April 18, 2024 08:11
@keithamus keithamus requested a review from jonrohan April 18, 2024 08:11
Copy link

changeset-bot bot commented Apr 18, 2024

🦋 Changeset detected

Latest commit: df417bb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@langermank langermank merged commit e867934 into main May 7, 2024
@langermank langermank deleted the drop-important-from-details-styling branch May 7, 2024 14:19
@primer primer bot mentioned this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doing find-in-page for text in GitHub PR/issue pages doesn’t cause expected auto-expansion of closed “details” elements that have matches
2 participants