Skip to content

feat: support key for table field content #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 19, 2025

Conversation

xrutayisire
Copy link
Contributor

Resolves: DT-2635: [S] AADev, I can use the key for each row and cell as a unique identifier

Description

  • We need to have a unique key for each row and cell. This would allow us and user to easily map over rows and cells having a unique identifier and prevent hacky things like JSON.stringify or using index.

Checklist

  • A comprehensive Linear ticket, providing sufficient context and details to facilitate the review of the PR, is linked to the PR.
  • If my changes require tests, I added them.
  • If my changes affect backward compatibility, it has been discussed.
  • If my changes require an update to the CONTRIBUTING.md guide, I updated it.

Preview

How to QA 1

Footnotes

  1. Please use these labels when submitting a review:
    ❓ #ask: Ask a question.
    💡 #idea: Suggest an idea.
    ⚠️ #issue: Strongly suggest a change.
    🎉 #nice: Share a compliment.

@xrutayisire xrutayisire force-pushed the xru/add-key-for-table-field-content branch from 52c6a9b to 165abef Compare March 18, 2025 14:07
Copy link
Contributor

@levimykel levimykel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🚀

@xrutayisire xrutayisire merged commit 2fc4152 into master Mar 19, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants