fix: prevent logging the retry message many times #382
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: N/A
Description
This PR prevents the client from logging its retry message many times in succession. The retry message is printed when an invalid or expired ref is tried.
The logger's history is tracked at the module level and will be shared across multiple clients.
The history will not be shared across multiple processes, such as during the different stages of a Next.js build. Still, this PR will reduce the total number of logs.
This PR also adds a
[@prismicio/client]
prefix to the retry message, consistent with the client's other logged messages.Checklist
Preview
This is an example log when building a Next.js website that has a cached expired ref.
Before
After
How to QA 1
.next
folder, which includes thefetch()
cache.Perform the above steps once with the latest published version, then again with this PR.
Footnotes
Please use these labels when submitting a review:
⚠️ #issue: Strongly suggest a change.
❓ #ask: Ask a question.
💡 #idea: Suggest an idea.
🎉 #nice: Share a compliment. ↩