Skip to content

chore(eslint): add ESLint configuration for Jest #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 7, 2023
Merged

chore(eslint): add ESLint configuration for Jest #108

merged 9 commits into from
Sep 7, 2023

Conversation

csouchet
Copy link
Member

@csouchet csouchet commented Aug 31, 2023 •
edited by tbouffard
Loading

  • install eslint-plugin-jest and eslint-plugin-jest-dom dependencies
  • add ESLint configuration for the tests of addons

@csouchet csouchet added chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) dependencies Pull requests that update a dependency (dev or runtime) depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first labels Aug 31, 2023
@github-actions
Copy link

github-actions bot commented Aug 31, 2023 •
edited
Loading

♻️ PR Preview 93cad9a has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

@csouchet csouchet force-pushed the add_eslint_for_jest branch 2 times, most recently from 3f0db5e to 7fd0323 Compare August 31, 2023 15:21
@tbouffard tbouffard removed dependencies Pull requests that update a dependency (dev or runtime) depends on another PR ⚠️ Pull request depending on another one. The depending must be merged first labels Sep 4, 2023
tbouffard
tbouffard reviewed Sep 4, 2023
View reviewed changes
@tbouffard tbouffard mentioned this pull request Sep 4, 2023
Open
23 tasks
@tbouffard
Copy link
Member

❌ The "Build" GH workflow fails

We re-run the failing job, I have also clear all GH actions cache used by this PR prior re-running. The error recurs with every run.

failed to load config from /home/runner/work/bv-experimental-add-ons/bv-experimental-add-ons/packages/demo/vite.config.ts
error during build:
Error: The package "@esbuild/linux-x64" could not be found, and is needed by esbuild.

If you are installing esbuild with npm, make sure that you don't specify the
"--no-optional" or "--omit=optional" flags. The "optionalDependencies" feature
of "package.json" is used by esbuild to install the correct binary executable
for your current platform.

evanw/esbuild#1819 (comment) provides a workaround but we shouldn't need it.
We use the --ignore-scripts flag in bpmn-visualization without problems, and we hadn't problem in this repository until recently while we used it.

I suspect that something changed in package-lock.json and created the issue.
I have just created #112 and I don't see this problem.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tbouffard
Copy link
Member

✔️ After merging from main and regenerating the package-lock.json file in f0d29b6, the esbuild installation error has gone! 🎉

@tbouffard tbouffard marked this pull request as ready for review September 7, 2023 05:27
@tbouffard tbouffard merged commit eefe805 into main Sep 7, 2023
@tbouffard tbouffard deleted the add_eslint_for_jest branch September 7, 2023 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbouffard tbouffard tbouffard left review comments

Assignees
No one assigned
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csouchet @tbouffard