[REFACTOR] Replace StyleIdentifier by the BpmnStyleIdentifier class #1581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbouffard
added
depends on another PR ⚠️
|
♻️ PR Preview e901c6b has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
|
♻️ PR Preview e901c6b has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
Rename to clarify the intent: mxgraph style identifiers for our custom BPMN implementation. This let remove the `BPMN_STYLE` prefix in all entries. Switch from enum to class: there is no need to enumerate or iterate on entries. They are not connected to each other, so enum has no sense here. This new implementation may introduce breaking changes for users implementing custom BPMN Theme. In particular, users that - customized edge start and/or end fill color - registered custom shape for edge and/or message flow icon Migration guide: - Instead of `StyleIdentifier.BPMN_STYLE_<name>`, use `BpmnStyleIdentifier .<name>` and update imports. - Values hold by the BpmnStyleIdentifier properties are left unchanged.
tbouffard
force-pushed
the
refactor/rename_style_identifier
branch
from
6ad4528 to
6f235c2
Compare
tbouffard
removed
the
depends on another PR ⚠️
|
Kudos, SonarCloud Quality Gate passed! |
csouchet
approved these changes
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename to clarify the intent: mxgraph style identifiers for our custom BPMN
implementation. This let remove the
BPMN_STYLEprefix in all entries.Switch from enum to class: there is no need to enumerate or iterate on properties.
They are not connected to each other, so enum makes no sense here.
This new implementation may introduce breaking changes for users implementing
custom BPMN Theme. In particular, users that
Migration guide:
StyleIdentifier.BPMN_STYLE_<name>, useBpmnStyleIdentifier.<name>and update imports.