[FEAT] Detect Complex Gateway #2250
Conversation
|
|
|
♻️ PR Preview 80207b9 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
|
♻️ PR Preview 80207b9 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
assynour
changed the title
| @@ -1685,6 +1686,12 @@ | |||
| <dc:Bounds x="2525" y="1250" width="90" height="14" /> | |||
| </bpmndi:BPMNLabel> | |||
| </bpmndi:BPMNShape> | |||
| <bpmndi:BPMNShape id="shape_complex_gateway_id" bpmnElement="complex_gateway_id"> | |||
There was a problem hiding this comment.
ℹ️ personal note: check if the rendering is ok when displaying the diagram, otherwise change the coordinates 😄
There was a problem hiding this comment.
nice! I wasn't sure that we document it, but yes it is documented!
Please, adjust shape coordinates to ensure new elements can be easily shown with a viewer and don't overlap with existing elements
docs/contributors/testing.md
Outdated
| * You have added changes in overlays: i.e. positioning, shapes, styling. | ||
| <br/><br/> | ||
| `overlays.rendering.test.ts` drives all visual tests for that part. A visual test only requires a BPMN diagram as input. | ||
| - You aim supporting a new BPMN elements or when the rendering of the BPMN elements change (existing |
There was a problem hiding this comment.
ℹ️ it is easier to see the changes with the GH rich diff
There was a problem hiding this comment.
However all IDE don't format/lint markdown in the same way. So I will revert extra changes.
We have to find common lint rules that we can always apply
assynour
added
enhancement
There was a problem hiding this comment.
Thanks for this PR which is globally good. Thanks for the documentation improvements based on your experience.
However, there are some elements that need to be changed
- The PR title doesn't follow what we are usually doing
- The PR description lacks of explanation and the link to the issue won't close it on PR merge (see https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests)
- The BPMN Support paragraph in the user document has not been updated (https://github.com/process-analytics/bpmn-visualization-js/blob/v0.26.2/docs/contributors/bpmn-support-how-to.md#elements-detection). If you need more guidance, please let me know. We can also improve the documentation about it. There is no need to display the new gateway icon for now. We will put it when the final rendering is implemented
- The PR used as an example to illustrate what to do for "BPMN element detection" are too old. We should mention this new PR and a more recent one instead
assynour
changed the title
|
Kudos, SonarCloud Quality Gate passed! |
fixes #793
Screenshot