Skip to content

[INFRA] Update wording "BPMN Visualization" to bpmn-visualization #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

csouchet
Copy link
Contributor

@csouchet csouchet commented Jan 4, 2023

Closes #196

@csouchet csouchet added the chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) label Jan 4, 2023
@csouchet csouchet requested a review from tbouffard January 4, 2023 16:20
@csouchet csouchet marked this pull request as ready for review January 4, 2023 16:20
@github-actions
Copy link

github-actions bot commented Jan 4, 2023

♻️ PR Preview 27b2fbe has been successfully destroyed since this PR has been closed.

🤖 By surge-preview

Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes about the R package renaming remains to apply
Otherwise, looks good

@@ -1,4 +1,4 @@
name: Update BPMN Visualization version in Examples repo
name: Update the version of the bpmn-visualization TypeScript library in Examples repo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -1,4 +1,4 @@
name: Update BPMN Visualization version in R repo
name: Update the version of the bpmn-visualization TypeScript library in R repo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content of this file matches process-analytics/bpmn-visualization-R#172

Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The references to the R package will be updated in #217, so everything is fine here

@tbouffard tbouffard merged commit 3fe46b2 into master Jan 10, 2023
@tbouffard tbouffard deleted the 196-Update_wording__BPMN_Visualization__to_bpmn-visualization branch January 10, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update wording "BPMN Visualization" to bpmn-visualization
2 participants