[prometheus-blackbox-exporter] Add missing port names to ServiceMonitor endpoints #5322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebhoss
requested review from
desaintmartin,
gianrubio,
monotek and
rsotnychenko
as code owners
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions. |
…or endpoints Since the port names are hardcoded in the service.yaml file, we can just reference them by name instead of templating their values. Signed-off-by: Sebastian Hoß <[email protected]>
|
Rebased on latest main branch |
Signed-off-by: MH <[email protected]>
Signed-off-by: André Bauer <[email protected]>
monotek
previously approved these changes
Jun 23, 2025
Signed-off-by: André Bauer <[email protected]>
monotek
requested changes
Jun 23, 2025
| @@ -1,7 +1,7 @@ | |||
| apiVersion: v2 | |||
| description: Prometheus Blackbox Exporter | |||
| name: prometheus-blackbox-exporter | |||
| version: 11.0.0 | |||
| version: 12.0.0 | |||
There was a problem hiding this comment.
imho this is currently a breaking change for anybody who uses this currently.
i would change it in a way that the default values you've set are only used if the ports are not set.
Signed-off-by: André Bauer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This correctly sets the port name in the generated ServiceMonitor for both the blackbox-exporter itself as well as the config-reloader. The templating for the port name of the blackbox-exporter was removed since the associated Service hardcodes the port name to
httpand does not allow to change it.Which issue this PR fixes
Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])pinging @desaintmartin @gianrubio @rsotnychenko @monotek since you guys are listed as maintainers in the Chart.yaml file.