[alertmanager] Variable to add extra k8s Objects #5636
Conversation
Signed-off-by: rakesh-von <[email protected]>
rakesh-von
force-pushed
the
feature/alertmanager_extraObjects
branch
from
1a35849 to
029783f
Compare
Signed-off-by: rakesh-von <[email protected]>
Signed-off-by: rakesh-von <[email protected]>
Signed-off-by: rakesh-von <[email protected]>
|
I'm not a fan of such additions. |
HI @monotek We are currently using gitops to add additional stuff but our aim is to not have multiple places from where a deployment can be changed or affected, rather have everything have from 1 source for the ease of maintenance and troubleshooting. Can you please consider this change? i am sure it will be helpful for others as well and people coming with weird error reports would anyhow come as they might not have enough helm experience? |
|
I mean error reports about stuff which is added in the additional manifests. |
ah ok, now i understand what you meant. but this feature is disabled by default and people enabling this would know the consequences of it i guess and i feel this should be fine as it is disabled by default. |
|
moreover this feature is available in other public helm repos as well and is widely used. for example https://github.com/VictoriaMetrics/helm-charts/blob/master/charts/victoria-metrics-agent/templates/extra-objects.yaml |
|
@naseemkullah thoughts? |
|
@naseemkullah and @monotek any updates please? |
rakesh-von
force-pushed
the
feature/alertmanager_extraObjects
branch
from
2372669 to
9afa8d0
Compare
rakesh-von
requested review from
walker-tom,
xiu,
desaintmartin,
gianrubio,
rsotnychenko,
GMartinez-Sisti,
QuentinBisson,
Xtigyro,
andrewgkew,
gkarthiks,
jkroepke and
scottrigby
as code owners
…metheus-community#5650) Signed-off-by: rakesh-von <[email protected]>
…metheus-config-reloader Docker tag to v0.82.2 (prometheus-community#5644) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: helm-charts-renovate-helper[bot] <203471071+helm-charts-renovate-helper[bot]@users.noreply.github.com> Signed-off-by: rakesh-von <[email protected]>
…eloader Docker tag to v0.82.2 (prometheus-community#5643) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: helm-charts-renovate-helper[bot] <203471071+helm-charts-renovate-helper[bot]@users.noreply.github.com> Signed-off-by: rakesh-von <[email protected]>
…5654) Signed-off-by: drfaust92 <[email protected]> Signed-off-by: rakesh-von <[email protected]>
Signed-off-by: rakesh-von <[email protected]>
Signed-off-by: rakesh-von <[email protected]>
Signed-off-by: rakesh-von <[email protected]>
Signed-off-by: rakesh-von <[email protected]>
rakesh-von
force-pushed
the
feature/alertmanager_extraObjects
branch
from
401d783 to
231d529
Compare
Signed-off-by: rakesh-von <[email protected]>
|
Hi @monotek and @naseemkullah - any updates please? |
|
Please stop asking the same question again and again. |
|
HI @naseemkullah did you get some time to review the PR please? |
|
This gets annoying. Closing and locking conversation... |
What this PR does / why we need it
This PR lets users add additional k8s objects to fulfill their custom needs like adding additional service or targetgroupbindings.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer
Checklist
[prometheus-couchdb-exporter])