Skip to content

Wrong error message in blackbox exporter libsonnet #2633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
konchinshih opened this issue Apr 2, 2025 · 0 comments
Open

Wrong error message in blackbox exporter libsonnet #2633

konchinshih opened this issue Apr 2, 2025 · 0 comments
Labels

Comments

@konchinshih
Copy link

What happened?

This line cause some misleading message when configmapReloaderImage is not provided.

Jsonnet Output:

RUNTIME ERROR: must provide version
        vendor/kube-prometheus/components/blackbox-exporter.libsonnet:31:28-56  object <defaults>
        vendor/kube-prometheus/components/blackbox-exporter.libsonnet:200:14-47 object <reloader>
        Field "image"
        Array element 1
        Field "containers"
        Field "spec"
        Field "template"
        Field "spec"
        Field "deployment"
        During manifestation

Did you expect to see some different?
Fix the error message to what it should be.

How to reproduce it (as minimally and precisely as possible):

local blackboxExporter = import 'kube-prometheus/components/blackbox-exporter.libsonnet';

blackboxExporter({
  name:: 'name',
  image:: 'image',
  namespace:: 'namespace',
  version:: 'version',
  kubeRbacProxy:: 'kubeRbacProxy',
})

Environment

{
  description = "kubernetes prometheus dev environment flake";

  inputs = {
    nixpkgs.url = "github:nixos/nixpkgs?ref=nixos-unstable";
  };

  outputs = { self, nixpkgs }:
    let
      system = "x86_64-linux";
      pkgs = import nixpkgs { inherit system; };
      systemFishConfig = "${pkgs.fish}/share/fish/config.fish";
    in
    {
      devShells.${system}.default = pkgs.mkShell {
        packages = with pkgs; [
          fish
          go-jsonnet
          jsonnet-bundler
          yq-go
          kustomize
          kubectl
          json2yaml
          yaml2json
        ];
        shellHook = ''
          exec fish -p "${systemFishConfig}" -C '
            function fish_prompt;
              set_color blue;
              echo -n "(nix-dev) ";
              set_color normal;
              echo -n $(basename $(pwd)) "> ";
            end;
          '
        '';
      };
    };
}

Anything else we need to know?:

konchinshih added a commit to konchinshih/kube-prometheus that referenced this issue Apr 5, 2025
Change misleading configmapReloader error message when
field is missing.

Fixes prometheus-operator#2633
konchinshih added a commit to konchinshih/kube-prometheus that referenced this issue Apr 19, 2025
Change misleading configmapReloader error message when
field is missing.

Fixes prometheus-operator#2633
konchinshih added a commit to konchinshih/kube-prometheus that referenced this issue May 4, 2025
Change misleading configmapReloader error message when
field is missing.

Fixes prometheus-operator#2633
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant