Deprecate thanosSelector and expose mixin._config.thanos config variable for thanos sidecar
#1543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
paulfantom
reviewed
Dec 9, 2021
arajkumar
force-pushed
the
add-thanos-targetgroup
branch
from
eef8e74 to
6a43cda
Compare
arajkumar
changed the title
targetGroup config variable
arajkumar
force-pushed
the
add-thanos-targetgroup
branch
from
6a43cda to
5a2b8b5
Compare
arajkumar
changed the title
thanosSelector and expose mixin._config.thanos config variable for thanos sidecar
…able for thanos sidecar This commit removes existing `thanosSelector` and exposes a single config variable `mixin._config.thanos` to customize thanos sidecar mixins. It follows same structure as https://github.com/thanos-io/thanos/blob/d2d74dac9878f633f1fb0e253bcc0b1cdea376d3/mixin/config.libsonnet Signed-off-by: Arunprasad Rajkumar <[email protected]>
arajkumar
force-pushed
the
add-thanos-targetgroup
branch
from
5a2b8b5 to
1fb864e
Compare
paulfantom
reviewed
Dec 13, 2021
There was a problem hiding this comment.
It might be good to keep it backward compatible just for now and remove it after 0.10.0.
We already have a few cases of config which will need to be deprecated after 0.10.0, so writing all those cases in one migration doc should be easier for users than going through PRs (we don't have changelog yet).
Signed-off-by: Arunprasad Rajkumar <[email protected]>
arajkumar
changed the title
thanosSelector and expose mixin._config.thanos config variable for thanos sidecarthanosSelector and expose mixin._config.thanos config variable for thanos sidecar
|
@paulfantom Can you please merge this? Thank you. |
arajkumar
added a commit
to arajkumar/kube-prometheus
that referenced
this pull request
Dec 17, 2021
Previous PR[1] which deprecated `thanosSelector` accidentally broke the usage of it. This commit restores the old behaviour along with newly introduced `thanos` config variable. [1] prometheus-operator#1543 Signed-off-by: Arunprasad Rajkumar <[email protected]>
5 tasks
arajkumar
added a commit
to arajkumar/kube-prometheus
that referenced
this pull request
Jan 5, 2022
Previous PR[1] which deprecated `thanosSelector` accidentally broke the usage of it. This commit restores the old behaviour along with newly introduced `thanos` config variable. [1] prometheus-operator#1543 Co-authored-by: Pawe? Krupa <[email protected]> Signed-off-by: Arunprasad Rajkumar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit deprecates existing
thanosSelectorand exposes a single config variablemixin._config.thanosto customize thanos sidecar mixins. It follows same structure as https://github.com/thanos-io/thanos/blob/d2d74dac9878f633f1fb0e253bcc0b1cdea376d3/mixin/config.libsonnetSigned-off-by: Arunprasad Rajkumar [email protected]
Type of change
What type of changes does your code introduce to the kube-prometheus? Put an
xin the box that apply.CHANGE(fix or feature that would cause existing functionality to not work as expected)FEATURE(non-breaking change which adds functionality)BUGFIX(non-breaking change which fixes an issue)ENHANCEMENT(non-breaking change which improves existing functionality)NONE(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Changelog entry
Please put a one-line changelog entry below. Later this will be copied to the changelog file.