Fix problems when enabling eks platform patch #1675
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a problem where users are unable to generate k8s manifests when they enable
platform: 'eks'
in their libsonnet configuration.An attempt for fixing this has been made in #1286, but it tried to fix all the platforms at once including the documentation. However, in this PR, I would like to focus on just fixing the problem when enabling
platform: 'eks'
part.Without this patch, user will get an error when they enable
platform: 'eks'
part like this:To fix the problem, this patch passes
$.values
to make those values available for the platform patches. Then, inaws-vpc-cni.libsonnet
, I changed those$.prometheus
to use values from$.values
or just hard-coded alternate values instead.I think I will submit follow-up patch to update documentation where necessary to reflect the fact that you need to set
platform:
inside thecommon
object, after this PR is merged.By the way, this is the first time for me to work with Jsonnet and kube-prometheus codebase, so please feel free to give me feedback if I misunderstood anything. Thank you very much.
Type of change
CHANGE
(fix or feature that would cause existing functionality to not work as expected)FEATURE
(non-breaking change which adds functionality)BUGFIX
(non-breaking change which fixes an issue)ENHANCEMENT
(non-breaking change which improves existing functionality)NONE
(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Changelog entry