Skip to content

Update for github.com/cespare/xxhash/v2 to avoid asm errors with go 1.17 #912

Closed
@dtrudg

Description

@dtrudg

The latest release, and master branch of prometheus/client_golang are using github.com/cespare/xxhash/v2 v2.1.1.

This dependency has an issue which prevents compilation of code into a plugin with the latest versions of Go. I.E. when using go 1.17 / 1.17.1 compiling a go plugin that imports prometheus/client_golang will result in:

# github.com/cespare/xxhash/v2
asm: xxhash_amd64.s:120: when dynamic linking, R15 is clobbered by a global variable access and is used here: 00092 (/home/dtrudg/go/pkg/mod/github.com/cespare/xxhash/[email protected]/xxhash_amd64.s:120)	ADDQ	R15, AX
asm: assembly failed

See: cespare/xxhash#54

Please could the dependency be updated for the next release (fixed in github.com/cespare/xxhash/v2 v2.1.2) ?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions