Skip to content

Proposal: Migrate from CircleCI to Github Actions #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hdost opened this issue Dec 22, 2021 · 2 comments
Closed

Proposal: Migrate from CircleCI to Github Actions #743

hdost opened this issue Dec 22, 2021 · 2 comments

Comments

@hdost
Copy link
Contributor

hdost commented Dec 22, 2021

The change seems relatively simple and there's no real benefit for this repo as it's a simple Linux java build anyhow.

Reference for How: https://docs.github.com/en/actions/migrating-to-github-actions/migrating-from-circleci-to-github-actions

hdost added a commit to hdost/client_java that referenced this issue Dec 22, 2021
* Also add builds for Java 11 and Java 17

Fixes prometheus#743
Relates prometheus#658

Signed-off-by: Harold Dost <[email protected]>
hdost added a commit to hdost/client_java that referenced this issue Dec 22, 2021
* Also add builds for Java 11 and Java 17

Fixes prometheus#743
Relates prometheus#658

Signed-off-by: Harold Dost <[email protected]>
hdost added a commit to hdost/client_java that referenced this issue Dec 22, 2021
* Also add builds for Java 11 and Java 17

Fixes prometheus#743
Relates prometheus#658

Signed-off-by: Harold Dost <[email protected]>
hdost added a commit to hdost/client_java that referenced this issue Dec 22, 2021
* Also add builds for Java 11 and Java 17

Fixes prometheus#743
Relates prometheus#658

Signed-off-by: Harold Dost <[email protected]>
hdost added a commit to hdost/client_java that referenced this issue Dec 22, 2021
* Also add builds for Java 11 and Java 17

Fixes prometheus#743
Relates prometheus#658

Signed-off-by: Harold Dost <[email protected]>
hdost added a commit to hdost/client_java that referenced this issue Dec 22, 2021
* Also add builds for Java 11 and Java 17

Fixes prometheus#743
Relates prometheus#658

Signed-off-by: Harold Dost <[email protected]>
hdost added a commit to hdost/client_java that referenced this issue Dec 22, 2021
* Also add builds for Java 11 and Java 17

Fixes prometheus#743
Relates prometheus#658

Signed-off-by: Harold Dost <[email protected]>
hdost added a commit to hdost/client_java that referenced this issue Dec 23, 2021
* Also add builds for Java 11 and Java 17

Fixes prometheus#743
Relates prometheus#658

Signed-off-by: Harold Dost <[email protected]>
hdost added a commit to hdost/client_java that referenced this issue Dec 23, 2021
* Replaces existing build
** Didn't enable other builds as there are currently failures.

Fixes prometheus#743
Relates prometheus#658

Signed-off-by: Harold Dost <[email protected]>
@fstab
Copy link
Member

fstab commented Dec 24, 2021

Hi @hdost, my understanding is that all projects in the Prometheus organization are built with CircleCI (client_golang, client_python, client_ruby, prometheus, alertmanager, pushgateway), and they use a common Prometheus ORB for cross-project tasks like releasing Docker images (not needed by client_java though, as we release via Maven central). Some Projects have Github actions as well, but as far as I can see it's not for releasing, but just for tasks like running a Go linter.

Having the same built tool makes it easy for Prometheus community members to understand the build process for other Prometheus projects. There should be a good reason to switch to a different build tool client_java while all the others use CircleCI. I'm not really missing anything with CircleCI. Do you have anything specific in mind?

@hdost
Copy link
Contributor Author

hdost commented Dec 24, 2021

That's logical. Will close.

@hdost hdost closed this as completed Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants