Remove Java runtime classes from kotlin release. #20607
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because we build lite and core totally separately, they can't both be depended on without producing conflicts. Our kotlin setup has been doing exactly this for a long time though, in order to share code between kotlin and kotlin-lite. Even *with* this change, it's invalid to depend on both lite and core, because they contain different builds of our boostrapped protos. However, they now share the internal `lite_runtime_only` target, which kotlin can reuse to share code. This prevents `lite` from getting linked into kotlin, allowing kt_jvm_export to properly strip out all classes from the Java runtime. Fixes #20566 PiperOrigin-RevId: 734375729
googleberg
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we build lite and core totally separately, they can't both be depended on without producing conflicts. Our kotlin setup has been doing exactly this for a long time though, in order to share code between kotlin and kotlin-lite. Even with this change, it's invalid to depend on both lite and core, because they contain different builds of our boostrapped protos. However, they now share the internal
lite_runtime_onlytarget, which kotlin can reuse to share code.This prevents
litefrom getting linked into kotlin, allowing kt_jvm_export to properly strip out all classes from the Java runtime.Fixes #20566
PiperOrigin-RevId: 734375729