Add bindings to the user propagator #344
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ignores Macos' DS_Store and some `nix` related files
Not tested yet, so there are probably many typos around still
many things are not ready yet, notably I'm not sure of the lifetimes of things. I skipped fresh entirely
Some things can likely still be improved, but this is a good initial implementation
This way there is no need for handles, it also makes it easier to add the `on_clause` API
|
So apparently Ubuntu ships with a version of |
The previous version half assumed there was no multithreading (no requierement for Sync), half assumed there was (it was using `ref` everywhere). This commit fully goes for the no multithreading version. - &mut where it makes sense - the UPSolver now owns the UserPropagators, to prevent potential aliasings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds bindings and an API for the user propagator and the
on_clausecallback.I would consider this still experimental, as I'm not fully sure of what
z3might do with my objects (e.g., weird lifetimes and thread safety).This also closes #343