Skip to content

SSL example #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

SSL example #971

wants to merge 4 commits into from

Conversation

Alex-Shirazi1
Copy link
Contributor

@Alex-Shirazi1 Alex-Shirazi1 commented Oct 15, 2021 •
edited by Haarolean
Loading

  • Breaking change? (if so, please describe the impact and migration path for existing applications:)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "X" next to an item)

  • No need to
  • Manually(please, describe, when necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "X" next to an item, otherwise PR will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings(e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

@Haarolean Haarolean self-requested a review October 15, 2021 08:09
Haarolean
Haarolean suggested changes Oct 15, 2021
View reviewed changes
docker/kafka-ui-ssl.yaml Outdated
KAFKA_CLUSTERS_0_ZOOKEEPER: zookeeper0:2181
KAFKA_CLUSTER_0_SSL_KEYSTORE_LOCATION: /var/private/ssl/kafka.server.keystore.jks
KAFKA_CLUSTER_0_SSL_KEYSTORE_PASSWORD: test1234
KAFKA_CLUSTER_0_SSL_TRUSTSTORE_LOCATION: /var/private/ssl/kafka.server.truststore.jks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also upload these keystores into a subdirectory inside docker directory please?

docker/kafka-ui-ssl.yaml Outdated
- zookeeper0
ports:
- '9092:9092'
environment:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how does kafka know which certificate to use? There are no volume binds for keystores

@Haarolean Haarolean added scope/infrastructure CI / Dev. Env type/enhancement En enhancement to an already existing feature labels Oct 15, 2021
@Haarolean Haarolean added the type/documentation Improvements or additions to documentation label Dec 7, 2021
This was linked to issues Dec 7, 2021
Guide on Connecting to a Secure Broker is incomplete #779
Closed
Support HTTPS connection #479
Closed
@Haarolean Haarolean removed a link to an issue Dec 28, 2021
Support HTTPS connection #479
Closed
@Haarolean Haarolean marked this pull request as draft January 14, 2022 07:08
@Haarolean Haarolean self-assigned this Jan 14, 2022
@Haarolean Haarolean linked an issue Feb 2, 2022 that may be closed by this pull request
Add docker-compose example with SSL secured kafka #929
Closed
@Haarolean Haarolean removed type/enhancement En enhancement to an already existing feature scope/infrastructure CI / Dev. Env labels Feb 2, 2022
@Haarolean
WIP
a21e686 
Signed-off-by: Roman Zabaluev <[email protected]>
@Haarolean Haarolean closed this Feb 7, 2022
@Haarolean Haarolean deleted the 929-kafka-ssl-example branch February 18, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Haarolean Haarolean Haarolean requested changes

Assignees

@Haarolean Haarolean

@5hin0bi 5hin0bi

Labels
type/documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add docker-compose example with SSL secured kafka Guide on Connecting to a Secure Broker is incomplete
3 participants
@Alex-Shirazi1 @Haarolean @5hin0bi