Fix f string expr split after #4680
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4677
My assumption on how the issue started is from a documentation issue on
iter_fexpr_spans
- the docs said "Spans are half-open ranges (left inclusive, right exclusive)", but it actually returns closed ranges. I assume the author of_get_illegal_split_indices
then saw that, and added one to the range, making the ranges include the char after the f-string expr.To fix this, I just removed that +1 on the ranges.
I looked at the other usages of
iter_fexpr_spans
, but all of them seem to properly use the ranges as closed.I updated the tests that were changed by this, it was a small subsection that looks fine, and since no other code tests were effected that supports that everything else uses the spans as closed. I also fixed the docs for
iter_fexpr_spans
to prevent this in the future.Checklist - did you ...
CHANGES.md
if necessary?