Skip to content

Added extendRequestParams to downloadItem() #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2018
Merged

Conversation

drola
Copy link
Contributor

@drola drola commented May 3, 2018

No description provided.

@psolom
Copy link
Owner

psolom commented May 3, 2018

Thanks for the contribution!
Have you tested this? How it works for you?

@drola
Copy link
Contributor Author

drola commented May 4, 2018

Let's start with the bug that I was trying to fix.
I pass a token between all requests to the backend to do authorization. Our users found out that everything works except downloading the files.When looking through the code I discovered that downloadItem() doesn't call fm.settings.callbacks.beforeSetRequestParams. Comparing that to other actions I figured out that calling extendRequestParams() is the most appropriate solution for downloadItem().

I tested this and the tokens are now passed to the download request as they should be.

@psolom psolom merged commit 7c9a14a into psolom:master May 4, 2018
@psolom
Copy link
Owner

psolom commented May 4, 2018

I see now, thanks for the details. Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants