feat: integrate v4 of the packet forward middleware #839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #839 +/- ##
==========================================
+ Coverage 11.94% 12.12% +0.17%
==========================================
Files 103 103
Lines 14324 14353 +29
==========================================
+ Hits 1711 1740 +29
Misses 12499 12499
Partials 114 114
☔ View full report in Codecov by Sentry. |
spoo-bar
reviewed
Aug 4, 2023
|
|
||
| firstHopEscrowAccount := sdk.MustBech32ifyAddressBytes(chainA.Config().Bech32Prefix, transfertypes.GetEscrowAddress(abChan.PortID, abChan.ChannelID)) | ||
| secondHopEscrowAccount := sdk.MustBech32ifyAddressBytes(chainB.Config().Bech32Prefix, transfertypes.GetEscrowAddress(bcChan.PortID, bcChan.ChannelID)) | ||
| thirdHopEscrowAccount := sdk.MustBech32ifyAddressBytes(chainC.Config().Bech32Prefix, transfertypes.GetEscrowAddress(cdChan.PortID, abChan.ChannelID)) |
There was a problem hiding this comment.
Shouldnt this be cdChan.Channeld? 🤔
Suggested change
| thirdHopEscrowAccount := sdk.MustBech32ifyAddressBytes(chainC.Config().Bech32Prefix, transfertypes.GetEscrowAddress(cdChan.PortID, abChan.ChannelID)) | |
| thirdHopEscrowAccount := sdk.MustBech32ifyAddressBytes(chainC.Config().Bech32Prefix, transfertypes.GetEscrowAddress(cdChan.PortID, cdChan.ChannelID)) |
mergify bot
pushed a commit
that referenced
this pull request
Aug 19, 2023
* feat: integrate v4 of the packet forward middleware * test: add e2e testing for pfm via interchaintest --------- Co-authored-by: Spoorthi <[email protected]> Co-authored-by: Jorge Hernandez <[email protected]> (cherry picked from commit 1baf9d4)
jhernandezb
added a commit
that referenced
this pull request
Aug 21, 2023
…pr-839 feat: integrate v4 of the packet forward middleware (backport #839)
spoo-bar
added a commit
that referenced
this pull request
Aug 25, 2023
* feat: integrate v4 of the packet forward middleware * test: add e2e testing for pfm via interchaintest --------- Co-authored-by: Spoorthi <[email protected]> Co-authored-by: Jorge Hernandez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR integrates
v4of thepacket-forward-middlewarefrom the ibc-apps repo. A summary of the integration path and some of the configurable options in the PFM can be found here.Testing
To assert that the PFM is working as intended I have included an e2e test which can be found in the directory
e2e. The e2e test utilizes interchaintest and makes use of a locally built Docker image. I have included some Make commands to simplify setting up heighliner, building the Docker image and running the tests.To run the test with the changes in this PR follow the directions below.
git clone https://github.com/jtieri/stargaze.git && git checkout feat/packet-forward-middlewaremake get-heighliner && make local-imageThe testing setup could be changed in any way you see fit and has mostly been included here as a means for verifying that the integration of the PFM is successful. Feel free to edit or completely remove this component of the PR!