[SG-133] upgrading to sdk v0.47 #845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
spoo-bar
commented
Aug 9, 2023
•
spoo-bar
commented
- Replacing tendermint with cometbft
- Updating sdk to 0.47
- Updating wasmd to 0.41
- Updating ibc-go to v7
- Removing REST stuff
- Replacing ibc-hooks fork with reference to github.com/cosmos/ibc-apps/modules/ibc-hooks/v7
- All the existing gov props for x/cron and x/globalfee are kept as legacy gov props. Will update them in later PR
- Fixing simapp references in tests
jhernandezb
reviewed
Sep 16, 2023
| @@ -157,7 +157,7 @@ DOCKER_BUF := $(DOCKER) run --rm -v $(CURDIR):/workspace --workdir /workspace $( | |||
| ############################################################################### | |||
| ### Protobuf ### | |||
| ############################################################################### | |||
| PROTO_BUILDER_IMAGE=ghcr.io/cosmos/proto-builder:0.9.0 | |||
| PROTO_BUILDER_IMAGE=ghcr.io/cosmos/proto-builder:0.14.0 | |||
There was a problem hiding this comment.
seems like the recommended version was 0.11.2 is there any difference with this version?
There was a problem hiding this comment.
Currently recommend version is > 0.11.5 for sdk 47.
Using 0.14.0 just to use the most upto date builder.
The latest image has some optimizations as well cosmos/cosmos-sdk#16343
| @@ -3,13 +3,12 @@ package statesync | |||
| import ( | |||
There was a problem hiding this comment.
we can remove this custom snapshotter if statesync works in v0.47 just need to check
fix start local node
…andlers remove min commission and min deposit ratio
jhernandezb
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.