Ensure Sensitive handling of PSCredentials; module version munging; DSC metadata in metadata.json #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit the result of Invoke-WebRequest to verify that a PowerShell module page can be hit while updating metadata.
Prior to this commit the versioning for the built Puppet module included the fourth digit as is often included in PowerShell module versions. Puppet tooling does not support four-digit versions. This commit adds a new private function, Get-PuppetModuleVersion, which can be used to translate a valid PowerShell module version into a valid Puppet module version. It does so by using the prerelease convention, mapping the fourth-digit of a PowerShell module version to the first digit of the prerelease tag. It further adds the ability to distinguish between rebuilt versions of an output module where the source is the same but the output is different because the builder was updated to fix a bug in type generation. This means that the Puppet module version for a PowerShell module will look like these examples: - 1.2.3 becomes 1.2.3-0-0 - 1.2.3.4 becomes 1.2.3-4-0 - 2.3.21 becomes 2.3.21-0-0, if rereleased it is then 2.3.21-0-1 This keeps the versions human-readable and mappable between the two packaging standards and also makes version comparison logic on our end easier.
This update adds a new hash to the puppetized module metadata, which includes the guid, module author, name, and version. This should provide a more directly discoverable set of info about the upstream PowerShell module without having to look around for the information.
DavidS
approved these changes
Apr 23, 2020
DavidS
changed the title
sheenaajay
approved these changes
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.